Added filter for projects and tasks#29
Conversation
ghost
assigned
There was a problem hiding this comment.
Very good works! 👍
Just some label to change to be correct.
Also, i think we need to just want to display the research bar by default and allow the user to display other filter with a popover choice like research in the navbar.
PS : You forgot filter by assigned and by labels
| <ion-label>Status</ion-label> | ||
| <ion-select [(ngModel)]="searchDone" (ionChange)="getDataFromApi()"> | ||
| <ion-option value="all" selected="true">All</ion-option> | ||
| <ion-option value="done">Done</ion-option> |
There was a problem hiding this comment.
It will be good to keep the same label for User Experience. The user only know open and closed
There was a problem hiding this comment.
Changed label Done and Not done to Open and Closed
| <ion-searchbar [(ngModel)]="searchName" (ionInput)="getDataFromApi()"></ion-searchbar> | ||
| </ion-item> | ||
| <ion-item> | ||
| <ion-label>Id</ion-label> |
There was a problem hiding this comment.
The user don't know the ID and can't read it. You need to put the ID in the list and the detail of the task if you want filter by ID
There was a problem hiding this comment.
Added Id to the list and details view
| <ion-option value="7">7</ion-option> | ||
| <ion-option value="8">8</ion-option> | ||
| <ion-option value="9">9</ion-option> | ||
| <ion-option value="10">10</ion-option> |
There was a problem hiding this comment.
It works for me but i thinks its better to just able to Sort by in place of filter by for the priority. But it's good no problem with that.
There was a problem hiding this comment.
I'll leave it as a filter by for now because I cannot think of a way to have the layout allow for an intuitive way to sort by parameter without clogging the UI with lot of junk
| <ion-searchbar [(ngModel)]="searchTerm" (ionInput)="getDataFromApi()"></ion-searchbar> | ||
| </ion-item> | ||
| <ion-item> | ||
| <ion-label>Id</ion-label> |
There was a problem hiding this comment.
The user don't know the ID and can't read it. You need to put the ID in the list and the detail of the project if you want filter by ID
There was a problem hiding this comment.
Added the ID to the view
|
Added filter by assigned |
There was a problem hiding this comment.
Good works! 👍
Please check your commits name to respect the max chars number. Don't hesitate to use description field in your commit if you need some other explanation.
I can't use the assigned field in the research option.
The field is not a select box but a text input and when i put a letter on it make an
Runtime Error
Cannot read property 'toLowerCase' of undefined
Maybe you can put the ID in the format #16 Location de poney escamotable to not add some line and make the interface more easy to use (UX)
The new show filter button is very good, but maybe it will be better to put it in the popover in the mainbar to replace actual bullshit and make less content by default in the work area.
|
Fixed the undefined bug and changed the format for ID on the UI. |
2 participants
What have you changed ?
...
How did you do that ?
...